Project

General

Profile

Request: SOCKS proxy support

Added by Paul Boven 5 months ago

SOCKS can be used to easily tunnel your data over e.g. SSH. Normally I just use a program like 'tsocks' to connect to audio streams, which are often add 'strange' TCP ports. However, audacious doesn't work with that.
As audacious already has network proxy settings, could we please add SOCKS 5 support ? The current proxy support doesn't work with SOCKS.


Replies (4)

RE: Request: SOCKS proxy support - Added by Thomas Lange 5 months ago

There is already a pull request for SOCKS support.
@John: Could you please take a look? Is it missing something?

https://github.com/audacious-media-player/audacious/pull/25
https://github.com/audacious-media-player/audacious-plugins/pull/45

RE: Request: SOCKS proxy support - Added by John Lindgren 5 months ago

The pull requests probably need rebasing since they're a couple years old, but I don't see any major problems with them.

@Thomas: Please go ahead and merge them, if the code works for you.

Minor nitpick: the "SOCKS proxy?" checkbox should say "Use SOCKS proxy" (without the question mark).

RE: Request: SOCKS proxy support - Added by Paul Boven 5 months ago

Thanks for your quick responses.

I have looked at the diffs from the two pull requests above, and managed to compile audacious-3.10.1 with them.
The socks proxy works with those patches. Note that I applied them 'by hand' because I couldn't get github to give me the actual patches (not a seasoned git user).
The file prefs-window.cc in audacious/src/libaudqt has by now been renamed to prefs-window-qt.cc.

RE: Request: SOCKS proxy support - Added by John Lindgren 5 months ago

Thanks for the feedback. I've merged the pull requests into master.

    (1-4/4)