Project

General

Profile

Resizable colunms

Added by Netslovdlyasnov Netslovdlyasnov over 7 years ago

Hi.
I've seen some talks about that feature but found no good answer.
So, please explain why the columns are not resizable?

it is very easy to implement:
diff --git a/src/libaudgui/list.c b/src/libaudgui/list.c
index 5a24274..f6c5c74 100644
--- a/src/libaudgui/list.c
++ b/src/libaudgui/list.c
@ -663,7 +663,7 @ EXPORT void audgui_list_add_column (GtkWidget * list, const
width * model->charwidth + model->charwidth / 2 + padding);
g_object_set ((GObject *) renderer, "xalign", (float) 1, NULL);
}
-
gtk_tree_view_column_set_resizable (tree_column, 1);
gtk_tree_view_append_column ((GtkTreeView *) list, tree_column);
}

Thank you.


Replies (12)

RE: Resizable colunms - Added by szymon krasuski over 7 years ago

audacious , someone needs to fork it. only option.

RE: Resizable colunms - Added by John Lindgren over 7 years ago

It's not as easy as you might think, if you want to do it right. If all you do is call gtk_tree_view_column_set_resizable(), you will still have to resize the columns manually every time you start Audacious and every time you add a new playlist.

RE: Resizable colunms - Added by Netslovdlyasnov Netslovdlyasnov over 7 years ago

I understand this, but what should i do if song name is longer than column?
do right click->song info on each song? I'd rather manually resize column.
Maybe it is possible to make it an option in preferences?

Why do you want to disable manual resizing of colunms at all?
It is available in mostly all programs where columns are present.

Even if there will be a smart algorithm to calculate column size, why should someone disable manual resizing?
Do you really think that someone would want to remember column sizes for playlist?

RE: Resizable colunms - Added by Brian Sepolen about 7 years ago

On my 40" HDTV, I can resize the window to view the full song name, but my netbook doesn't have the real estate to do so. Resizing the columns would be nice in that situation.

RE: Resizable colunms - Added by Grant Farnsworth almost 7 years ago

The need to resize the columns should be apparent to anyone who uses audacious--song names frequently don't fit in the space provided, particularly if they are not named well and all have the same first 20 characters. The little dividers make it look like you can resize columns, but inexplicably, you can't. I personally use the patch provided by the OP and the behavior is perfect. I'm not sure how you can say that's not doing it right, John. It is a very great improvement over the default Audacious behavior and from what I can tell has no negative effects whatsoever. It's not necessary that the column size be remembered from one session or playlist to another. The defaults are fine, but in those cases where one wants to view more information about one of the fields, the ability to resize is key. Are there any gui's around that don't allow you resize columns of this type? It must be few because it's a poor usability decision.

It's a little annoying to have to download the source, edit list.c, add a single line (the call to gtk_tree_view_column_set_resizable), recompile and install on all my computers, but it's worth it so I can see my full song names if I want/need to.

RE: Resizable colunms - Added by szymon krasuski almost 7 years ago

also sorting thingy: by track, name, album et...

RE: Resizable colunms - Added by Hatta Hatta almost 7 years ago

Grant Farnsworth wrote:

The need to resize the columns should be apparent to anyone who uses audacious

You are not kidding. This was the very_first_thing I noticed after installing audacious. And it's an absolute show-stopper. Every other piece of software, from simple file managers to torrent clients, to spreadsheets, etc, allows resizing of columns. Every single one. You should be ashamed of yourselves.

RE: Resizable colunms - Added by John Lindgren almost 7 years ago

(1) This is free software. If you don't like the way it is, change it. No one is going to stop you.

(2) I realize a lot of people want this feature, and I have put some work into it, but it's not finished yet. I also have a life and work a full-time job. I have put hundreds of hours of my free time into Audacious, and I earn absolutely nothing for it. If all the thanks I get for that is "You should be ashamed of yourself", I'm likely to drop the project altogether. Is that what you want?

RE: Resizable colunms - Added by Ariadne Conill almost 7 years ago

We generally tend to take time on implementing features so that it will be properly implemented. If you want a shoddy application full of crappy hacks, by all means, feel free to fork it.

RE: Resizable colunms - Added by Anonymous almost 7 years ago

So I see that this feature has landed, and it works well for me. Thank you for taking the time to do it right. For your next trick, it would be nice if clicking on the column would sort by that parameter (like foobar2000).
Please don't let the juvenile, empty demands/threats discourage you. Audacious is an awesome player with and it doesn't need forked. Just remember that for every loud-mouthed discontent, you have loads of satisfied and grateful users.

RE: Resizable colunms - Added by John Lindgren almost 7 years ago

Thanks for the vote of confidence. :) Actually, I wasn't finished. The rest of the changes needed to properly support resizable columns (including restoring the column sizes on startup and synchronizing them between playlists) have just now landed in Git master of GTK+ and audacious-plugins. So with Audacious 3.4 running on top of GTK+ 3.8, everything will be lovely.

RE: Resizable colunms - Added by Netslovdlyasnov Netslovdlyasnov almost 7 years ago

John,
sorry for the interference, I just want audacious to get better and better, think that's what you want too. :)
John, you are doing a great job!

    (1-12/12)