Bug #1035
[meson] qtaudio plugin should be optional, independently of other qt5 code
0%
Description
Extremely nitpicky I know, but someone might be happy to avoid the extra dependency.
Disabling it doesn't lose any functionality that Audacious can't already do on its own. QtMM has some OpenAL code but it's not wired up as a backend there, so we unfortunately can't have a cursed jenga tower of audacious->qtmm->openal->jackd.
History
#1
Updated by John Lindgren almost 4 years ago
Updated by - Category changed from plugins/qtui to meson
- Subject changed from qtaudio plugin should be optional, independently of other qt5 code to [meson] qtaudio plugin should be optional, independently of other qt5 code
Hmm, it's already optional with autoconf/make-based builds.
#2
Updated by Thomas Lange almost 4 years ago
Updated by - File 0001-Make-QtMultimedia-output-optional-v2.patch 0001-Make-QtMultimedia-output-optional-v2.patch added
Could you please test the attached patch? I guess that's the right fix.
#3
Updated by Enne Eziarc almost 4 years ago
Updated by Thomas Lange wrote:
Could you please test the attached patch? I guess that's the right fix.
That one works, but it makes it an automagic dependency if the build host has the library installed. Applying both seems like the right answer here?
#4
Updated by Thomas Lange almost 4 years ago
- Status changed from New to Closed
Enne Eziarc wrote:
Applying both seems like the right answer here?
I have committed both patches together now. Thanks for the report and the proposed fix.
Marking as closed.
#5
Updated by Thomas Lange almost 4 years ago
- Target version set to 4.1
