Bug #469: Qt: Accelerators are not translated correctly - Audacious - OLD, PLEASE USE GITHUB DISCUSSIONS/ISSUES - Redmine

Bug #469

Qt: Accelerators are not translated correctly

Added by Thomas Lange about 10 years ago. Updated about 10 years ago.

Status:

Closed

Priority:

Minor

Assignee:

Category:

libaudqt

Target version:

3.6

Start date:

October 14, 2014

Due date:

% Done:

100%

Estimated time:

Affects version:

3.6

Description

translate_str() in libaudqt/util.cc
assumes the accelerator is always the prefix of a single word.
This is not always true.

Some accelerators are conventions or are placed somewhere else to prevent conflicts.

My suggestion is to translate the first underscore in all cases.
At least for the German translation this has no side effects.

Example.png (3.55 KB) Example.png	Button with wrong accelerator	Thomas Lange, October 14, 2014 16:27
translate_str.patch (1.34 KB) translate_str.patch		Thomas Lange, October 18, 2014 17:35

History

#1 Updated by John Lindgren about 10 years ago

How about using str_replace_char()?

#2 Updated by Thomas Lange about 10 years ago

I think that's fine.
All translated strings should contain only one accelerators already.
And I doubt that translators use underscores for other purposes than accelerators.

#3 Updated by Ariadne Conill about 10 years ago

My concern with str_replace_char() is multibyte safety, i.e. CJK translations. If you want to change the behaviour to translate the first underscore always, that is fine.

#4 Updated by Thomas Lange about 10 years ago

File 01_translate_str.patch added
File 02_translate_str.patch added

John, what do you think about this?
Can str_replace_char() be used for these translations?

If not, we can use one of the attached patches.

#5 Updated by John Lindgren about 10 years ago

William Pitcock wrote:

My concern with str_replace_char() is multibyte safety, i.e. CJK translations. If you want to change the behaviour to translate the first underscore always, that is fine.

All of our translations are UTF-8, so multibyte characters should (thankfully) not be an issue.

#6 Updated by Thomas Lange about 10 years ago

File 03_translate_str.patch added

OK, please take a look on the attached patch.

Two questions:
Is str_copy() the right function to use here or should it be str_to_utf8()?
What is the intention of "src"? Using "str" instead also works correctly.