Project

General

Profile

Bug #859

.wsz skins cannot be used on Windows

Added by John Lindgren 6 months ago. Updated about 2 months ago.

Status:
New
Priority:
Minor
Assignee:
-
Category:
win32
Target version:
-
Start date:
January 09, 2019
Due date:
% Done:

0%

Estimated time:
Affects version:

Description

The current scheme uses the external "unzip" program which generally isn't present on Windows.

We could ship an "unzip.exe" along with the Windows build, but it would be better if we could read the .wsz/.zip files directly through the VFS layer, without running an external .exe and creating temporary files on the C: drive.

History

#1 Updated by John Lindgren 6 months ago

  • Description updated (diff)

#2 Updated by Carlo Bramini 4 months ago

It is possible to handle directly ZIP files on Windows with some API, but in my opionion, since Audacious is already released with zLib, perhaps it would be worth to just import the small unzip.c and unzip.h from zlib sources, into contrib/minizip:

https://github.com/madler/zlib/tree/master/contrib/minizip

and free all platforms from the dependency to an external tool.
In this way, the skins will be loaded directly in memory from the ZIP file, without the need to unpack them on disk, like you said.

Sincerely.

#3 Updated by John Lindgren 4 months ago

minizip looks like a good option.

#4 Updated by Hieronymous Anonymous about 2 months ago

Has this bug been fixed?

Also available in: Atom PDF