Project

General

Profile

Feature #892

Follow symlinks when adding directory

Added by Anonymous over 5 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
libaudcore
Target version:
4.1
Start date:
June 10, 2019
Due date:
% Done:

100%

Estimated time:
Affects version:
3.10.1

Description

I started using git-annex for managing my music collection, which uses symlinks.

When I add a single file to audacious (audacious artist/album/file.flac), it opens the file flawlessly, but when I try to add a directory (audacious artist/album) it fails (“No files found.”).

Steps to reproduce:
  • mkdir -p tmp/subdir
  • cd tmp
  • Copy an audio file in this directory and name it file.flac
  • audacious . → replaces audacious queue with that file
  • ln -s ../file.flac subdir (create symlink to file.flac in subdirectory)
  • audacious subdir/file.flac → also works
  • audacious subdir → fails with (“No files found.”)

My audacious version: 3.10.1 (debian buster)

audacious.log (11.9 KB) audacious.log Anonymous, June 11, 2019 15:35

History

#1 Updated by Michael Schwendt over 5 years ago

Your steps are odd and confusing. If you copy file.flac into subdir, in which directory do you run the ln command?

Anyway, for sake of reproducibility, show full "ls -lR" output from the top directory and run audacious with option -V for verbose output. What do you get then for your testcase?

#2 Updated by Anonymous over 5 years ago

Sorry, I may have been unclear: I created the temporary directory and subdirectory in one shot with mkdir -p to save one step (but only cd’ed into tmp. I copied file.flac in the tmp directory (the current working directory).

ls -lR:

.:
total 4684
-rw-r--r-- 1 simon simon 4790753 Jun 11 15:30 file.flac
drwxr-xr-x 2 simon simon    4096 Jun 11 15:30 subdir

./subdir:
total 0
lrwxrwxrwx 1 simon simon 12 Jun 11 15:30 file.flac -> ../file.flac

I attached the output of audacious -V subdir

#3 Updated by John Lindgren over 5 years ago

This is currently the expected behavior. Adding a directory adds only regular files (and no playlist files), to guard against infinite recursion.

We could probably relax the rule and allow adding symlinks to regular files (but still no symlinks to directories).

#4 Updated by Anonymous over 5 years ago

That would be helpful, git-annex only creates symlinks for files and not for directories.

#5 Updated by John Lindgren over 5 years ago

  • Subject changed from Does not follow symlinks when adding directory to Follow symlinks when adding directory
  • Tracker changed from Bug to Feature

#6 Updated by John Lindgren about 5 years ago

  • Target version deleted (3.10.1)

#7 Updated by Heikki Levanto over 4 years ago

Hi,
This "feature" just hit me too. I was messing about a script to produce shuffled playlists that keep some tracks together, and decided to use symlinks for that. The script works fine, but Audacious will not open the files, since they are symlinks. I would appreciate if you relaxed the check to allow symlinks to regular files to be opened.

Using version 3.10.1-1 on Debian/Buster.

#8 Updated by Heikki Levanto over 4 years ago

P.S. It is mildly confusing that the file open dialog follows symlinks fine, and I can open a track that is a symlink to a file elsewhere. The only place where symlinks fail to open is when I open a directory that contains a symlink.

#9 Updated by John Lindgren almost 4 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed
  • Category set to libaudcore

#10 Updated by Thomas Lange almost 4 years ago

  • Target version set to 4.1

Also available in: Atom PDF