Bug #1179: Length of ffaudio-handled streams from #1160 & #1176 are the dreaded "419:57:08" instead of zero. - Audacious - OLD, PLEASE USE GITHUB DISCUSSIONS/ISSUES - Redmine

Bug #1179

Length of ffaudio-handled streams from #1160 & #1176 are the dreaded "419:57:08" instead of zero.

Added by Jim Turner over 2 years ago. Updated almost 2 years ago.

Status:

Closed

Priority:

Minor

Assignee:

Category:

plugins/ffaudio

Target version:

4.3

Start date:

August 08, 2022

Due date:

% Done:

100%

Estimated time:

Affects version:

4.2

Description

This is a follow-on to closed Issue #1160, and perhaps #1176, discovered during testing of both. Streams not being set to zero length. Here's a patch that has seemed to work well for me from some other code for quite some time now for both continuous and time-limited streams, and files.

ffaudio-core.cc.diff (583 Bytes) ffaudio-core.cc.diff		Jim Turner, August 08, 2022 01:05
ffaudio-core.cc.diff (584 Bytes) ffaudio-core.cc.diff		Jim Turner, August 08, 2022 17:49

History

#1 Updated by Jim Turner over 2 years ago

File ffaudio-core.cc.diff ffaudio-core.cc.diff added

Oops - I had been using "if ((int)ic->duration != 0)" forever, but when looking it it here I suddenly thought that negative duration values didn't make sense so I changed it to "if ((int)ic->duration > 0)". I then discovered a case where it DOES, and reverting it back to the former works returning the correct time, so updated the attachment here.

Jim